Fix mistaken type annotation - #184
Open
mgax wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #179 I added a broken type annotation:
Since
for_useris a classmethod, its first argument is a class, not an instance. The correct annotation would be:I have checked both versions by running
uv tool run --with=. ty check /tmp/typing-sandbox.pyin the django-ninja-jwt worktree against this sample file:Apologies for the mistaken PR – I had tested the change locally but it seems I was not careful 🙈
I would be happy to add
ty checkto CI if that contribution would be accepted.