-
Notifications
You must be signed in to change notification settings - Fork 0
Implemented rules for the Workflow Execution Phase. #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented rules for the Workflow Execution Phase. #41
Conversation
…orkflow Execution Phase.
elichad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues with the tests - but the SHACL looks good to me, so hopefully there are no major issues hiding :)
Aside from that, just a few small tweaks suggested.
rocrate_validator/profiles/five-safes-crate/should/11_workflow_execution_phase.ttl
Outdated
Show resolved
Hide resolved
tests/integration/profiles/five-safes-crate/test_5src_11_workflow_execution.py
Outdated
Show resolved
Hide resolved
tests/integration/profiles/five-safes-crate/test_5src_11_workflow_execution.py
Outdated
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/must/11_workflow_execution_phase.ttl
Outdated
Show resolved
Hide resolved
tests/integration/profiles/five-safes-crate/test_5src_11_workflow_execution.py
Outdated
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/must/11_workflow_execution_phase.ttl
Outdated
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/must/11_workflow_execution_phase.ttl
Outdated
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/must/11_workflow_execution_phase.ttl
Outdated
Show resolved
Hide resolved
tests/integration/profiles/five-safes-crate/test_5src_11_workflow_execution.py
Outdated
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/must/11_workflow_execution_phase.ttl
Show resolved
Hide resolved
rocrate_validator/profiles/five-safes-crate/must/11_workflow_execution_phase.ttl
Show resolved
Hide resolved
elichad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more suggestion - just a simplification to make future maintenance easier.
Otherwise, this looks good to me, so approving.
This PR addresses #37
Rules implemented
(i) The Workflow Execution object is the only entity in this phase that is typed
schema:CreateAction.(ii) This was implemented by requiring that the name of the Workflow Execution object is of type string and is at least 10 characters long.
(iii) This rule is implemented implicitly within the others. For example the RootDataEntity MUST mention a CreateAction entity which is assumed to be the Workflow Execution object in this phase (there is only one CreateAction object in the crate's graph).