Skip to content

Ensure frontend typecheck runs in CI#14

Closed
hoangsvit wants to merge 2 commits into
mainfrom
codex/fix-ci-failure-in-gitpilot-main-branch
Closed

Ensure frontend typecheck runs in CI#14
hoangsvit wants to merge 2 commits into
mainfrom
codex/fix-ci-failure-in-gitpilot-main-branch

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Motivation

  • Prevent type-related regressions from reaching the build stage by running an explicit frontend typecheck in CI after dependencies are installed and before the frontend build.
  • Confirm that the React entrypoint src/main.tsx is using React.StrictMode rendering so the app renders correctly at runtime.

Description

  • Add a Typecheck frontend step to .github/workflows/ci.yml that runs npm run typecheck immediately after npm ci and before npm run build.
  • Do not replace npm ci in CI and keep the Linux/Windows/macOS artifact build/upload steps unchanged.
  • No changes were required to src/main.tsx because it already contains the requested React.StrictMode render setup.
  • package-lock.json was checked with npm install, and no lockfile update was necessary in this checkout.

Testing

  • Ran npm ci --prefer-offline --no-audit --progress=false which completed successfully and populated node_modules for local verification. (succeeded)
  • Ran npm run build and the frontend production build completed successfully. (succeeded)
  • Ran npm run typecheck and TypeScript checks passed with no errors. (succeeded)
  • Ran npm run tauri:check which failed locally because the container is missing the system glib-2.0 pkg-config dependency required by the Tauri/GTK toolchain; this is an environment issue and CI installs Linux Tauri system dependencies prior to this step. (failed due to missing system dependency)

Codex Task

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@github-actions

Copy link
Copy Markdown

GitPilot build artifacts are ready

Download the desktop builds from this workflow run's artifacts:

  • Windows: gitpilot-windows
  • macOS: gitpilot-macos
  • Linux: gitpilot-linux

@hoangsvit hoangsvit closed this Jun 27, 2026
@hoangsvit hoangsvit deleted the codex/fix-ci-failure-in-gitpilot-main-branch branch June 27, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant