Ensure frontend typecheck runs in CI#14
Closed
hoangsvit wants to merge 2 commits into
Closed
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
GitPilot build artifacts are readyDownload the desktop builds from this workflow run's artifacts:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
src/main.tsxis usingReact.StrictModerendering so the app renders correctly at runtime.Description
Typecheck frontendstep to.github/workflows/ci.ymlthat runsnpm run typecheckimmediately afternpm ciand beforenpm run build.npm ciin CI and keep the Linux/Windows/macOS artifact build/upload steps unchanged.src/main.tsxbecause it already contains the requestedReact.StrictModerender setup.package-lock.jsonwas checked withnpm install, and no lockfile update was necessary in this checkout.Testing
npm ci --prefer-offline --no-audit --progress=falsewhich completed successfully and populatednode_modulesfor local verification. (succeeded)npm run buildand the frontend production build completed successfully. (succeeded)npm run typecheckand TypeScript checks passed with no errors. (succeeded)npm run tauri:checkwhich failed locally because the container is missing the systemglib-2.0pkg-config dependency required by the Tauri/GTK toolchain; this is an environment issue and CI installs Linux Tauri system dependencies prior to this step. (failed due to missing system dependency)Codex Task