Skip to content

Refactor division operations to use native Python 3 semantics#1091

Merged
shankari merged 15 commits intoe-mission:masterfrom
shankari:py3-cleanup-migration-artifacts
Mar 26, 2026
Merged

Refactor division operations to use native Python 3 semantics#1091
shankari merged 15 commits intoe-mission:masterfrom
shankari:py3-cleanup-migration-artifacts

Conversation

@shankari
Copy link
Copy Markdown
Contributor

  • Transition from old_div to native division across the codebase, ensuring consistent behavior in division operations. This change finally finishes up the migration with Python 3 from 10 years ago and makes the code easier to read. We have added one test to capture a branch that was modified but not covered previously.
    • The transition was staged in batches to make it easier to identify and fix any regressions
  • Remove unused files

TODO:

  • there is a bad condition in cfc_webapp.py
if round((duration - new_duration) / new_duration > 100) > 0:

That has been around forever; we should fix that in the next round

@shankari shankari requested a review from JGreenlee March 26, 2026 05:56
@shankari shankari merged commit 04fc597 into e-mission:master Mar 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant