Skip to content

Add Variable::from_usize - #9

Open
dhardy wants to merge 2 commits into
dylanede:masterfrom
dhardy:master
Open

Add Variable::from_usize#9
dhardy wants to merge 2 commits into
dylanede:masterfrom
dhardy:master

Conversation

@dhardy

@dhardy dhardy commented Sep 11, 2018

Copy link
Copy Markdown

Rationale: I have a unique reproducible way of generating keys per variable; using that saves me from creating a Variable → key map.

Comment thread src/lib.rs
@schell

schell commented Oct 16, 2019

Copy link
Copy Markdown

Oh, look at that. You did!

@dhardy

dhardy commented Oct 16, 2019

Copy link
Copy Markdown
Author

Yes, I did. This crate appears unmaintained. For my use-case, I'll probably move kas away from Cassowary anyway because it is inefficient and hard to debug.

@schell

schell commented Oct 16, 2019

Copy link
Copy Markdown

What will you use instead? Are the inefficiencies unable to be overcome with some profiling?

@dhardy

dhardy commented Oct 17, 2019

Copy link
Copy Markdown
Author

I'm mostly done with replacement code for my case which isn't quite as flexible but good enough and a lot simpler overall. I'll link to it when I'm done.

Inefficiencies are mostly because of the number of allocations this lib does, I think. Haven't looked into it much and it may still be good enough.

@dhardy

dhardy commented Oct 17, 2019

Copy link
Copy Markdown
Author

What will you use instead?

My replacement code is mostly done now, and very specific to my use-case (widget placement). See:

The latter is the heart of this system: lots of code injected per widget (I am hoping this doesn't cause issues when scaling to complex UIs; it also needs adjustment to handle dynamic content).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants