Skip to content

Added support for tetrads to OSRef.php. - #21

Open
stevegoddard wants to merge 7 commits into
dvdoug:masterfrom
stevegoddard:tetrad-support
Open

Added support for tetrads to OSRef.php.#21
stevegoddard wants to merge 7 commits into
dvdoug:masterfrom
stevegoddard:tetrad-support

Conversation

@stevegoddard

@stevegoddard stevegoddard commented Apr 16, 2019

Copy link
Copy Markdown
Contributor

Updated OSRef.php to accept tetrads and convert them to eastings / northings.
Updated OSRef.php to allow export to tetrad (toGridReference method).
The tetrad grid letters go in a different orientation to the main OS grid (start bottom left and run vertically). They also contain the letter I and exclude the letter O.
A lot of wildlife data is recorded at tetrad resolution so hopefully this will be useful functionality.

@dvdoug

dvdoug commented Jul 21, 2019

Copy link
Copy Markdown
Owner

@stevegoddard I'm happy to have this functionality added to the library, but since Tetrads seem to be not be an official OS referencing system, I think it would be clearer if it were to have a dedicated OSRef::fromTetrad method? What do you think?

@stevegoddard

stevegoddard commented Jul 24, 2019

Copy link
Copy Markdown
Contributor Author

@stevegoddard I'm happy to have this functionality added to the library, but since Tetrads seem to be not be an official OS referencing system, I think it would be clearer if it were to have a dedicated OSRef::fromTetrad method? What do you think?

@dvdoug I can see your point. This would mean that anyone using the package would need to check the length of the grid ref before calling the correct method. Having the package check the length itself seems neater and easier. Up to you. If you want me to move it to it's own method I'll happily do that.

@dvdoug

dvdoug commented Aug 18, 2019

Copy link
Copy Markdown
Owner

Since a Tetrad uses a different grid direction, this is something people would need to know anyway though? Or am I misunderstanding?

@stevegoddard

Copy link
Copy Markdown
Contributor Author

Since a Tetrad uses a different grid direction, this is something people would need to know anyway though? Or am I misunderstanding?

We get data (wildlife sightings) in all different resolutions - often mixed together. So records for 1km grid squares (i.e. SO2242) and 2km (tetrad) squares (i.e. SO24G). Any grid ref 5 characters long (provided it's not an error) is a tetrad. So for us it's just simpler if the system checks the length and does the conversion. Just seems simpler - if it's 5 chars it must be a tetrad.

@dvdoug
dvdoug force-pushed the master branch 2 times, most recently from 9a2fc14 to a51958d Compare April 24, 2021 21:12
@dvdoug
dvdoug force-pushed the master branch 2 times, most recently from c08befb to 079e4d5 Compare August 26, 2021 21:51
@dvdoug
dvdoug force-pushed the master branch 4 times, most recently from 48e916b to a64be84 Compare October 10, 2021 00:39
@dvdoug
dvdoug force-pushed the master branch 5 times, most recently from 8fbe41c to 696ad70 Compare November 11, 2021 19:02
@dvdoug
dvdoug force-pushed the master branch 2 times, most recently from aec3885 to 6ef80c8 Compare April 18, 2022 23:03
@dvdoug
dvdoug force-pushed the master branch 3 times, most recently from 0d5f345 to adda176 Compare March 22, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants