[iOS/macOS] Rename onboarding shared pixel params and bucket daysSinceInstall - #6120
Open
rachelmcr wants to merge 2 commits into
Open
[iOS/macOS] Rename onboarding shared pixel params and bucket daysSinceInstall#6120rachelmcr wants to merge 2 commits into
rachelmcr wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 857f673. Configure here.
Contributor
Author
|
Note: We shouldn't merge this until the pipeline is updated to accommodate the changes: https://app.asana.com/1/137249556945/project/1108686900785972/task/1216871249295897?focus=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1202818073656551/task/1217051716311541?focus=true
Tech Design URL:
CC:
Description
Updates the onboarding shared pixel parameters as agreed in New parameter names and buckets:
event,installType,daysSinceInstalldaysSinceInstallvalues, no longer dropping values over 28 (instead using a28+bucket)Testing Steps
m_mac_onboarding_welcomeis shown with parametersevent,installType,daysSinceInstall(no parameterse,it,d).daysSinceInstalluses a bucket value corresponding to the days since the app was originally installed (e.g.0,1-3,28+).Impact
None: Internal tooling
Internal references:
Definition of Done | Engineering Expectations | Tech Design Template
Note
Low Risk
Analytics-only pixel parameter changes with no user-facing behavior; downstream dashboards must expect new keys and bucket values instead of legacy
e/it/d.Overview
Aligns onboarding shared pixels on iOS and macOS with clearer parameter names and bucketed install-age reporting.
Parameter renames on fired pixels:
e→event,it→installType,d→daysSinceInstall. The handler andOnboardingSharedPixelEventparameters map, plus iOS/macOSparams_dictionary.json5, are updated together.daysSinceInstallis no longer a raw day count capped at 28 (older installs omitted the param). It now sends string buckets:0,1-3,4-10,11-28, and28+for 29+ days. Tests cover each bucket and the negative-day omission case.Reviewed by Cursor Bugbot for commit f658b12. Bugbot is set up for automated code reviews on this repo. Configure here.