Move rescope token request to IO thread#7869
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1213530835574684?focus=true
Description
Moves the network request that happens in
GetScopedSyncAuthTokenHandlerto aniothread instead of trying to do it on thejava bridgethread (which is for JS->Native comms).Steps to test this PR
Note
Medium Risk
Moves token rescoping into an injected app-level coroutine on the IO dispatcher, introducing async behavior that could affect response timing/cancellation and test determinism if dispatchers/scopes are misconfigured.
Overview
GetScopedSyncAuthTokenHandlernow performssyncApi.rescopeTokenasynchronously by launching on an injected@AppCoroutineScopewithdispatcherProvider.io(), instead of executing inline on the message handler thread.Tests are updated to inject a
CoroutineTestRuletest scope/dispatcher provider so the new coroutine-based behavior remains verifiable while keeping the existing success/error response and pixel assertions intact.Written by Cursor Bugbot for commit 389af64. Configure here.