Lint cleanup: fix Overdraw issues across 9 modules#7855
Open
Lint cleanup: fix Overdraw issues across 9 modules#7855
Conversation
Add tools:ignore="Overdraw" to 45 layout files where root elements have intentional backgrounds that lint falsely flags as overdraw (lint infers wrong theme). Remove unnecessary transparent background from serp-logos easter egg layout. Remove 46 Overdraw entries from lint baselines. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Author
|
@mikescamell can you check the serp easter logos change? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1157893581871903/task/1213509412140215
Description
Fix 46 Overdraw lint issues across 9 modules (excluding
:app).All issues are false positives — lint incorrectly infers
Theme.Holoinstead of the actual DuckDuckGo theme, causing it to report root element backgrounds as overdraw when the theme already paints a background.Changes:
tools:ignore="Overdraw"to 45 layout files with intentional backgrounds (activity/fragment backgrounds, list item ripples, popup menu backgrounds, custom drawables)@color/transparentbackground from serp-logos easter egg layout (1 file)Modules affected: browser-ui, autofill-impl, sync-impl, vpn-impl, voice-search-impl, serp-logos-impl, saved-sites-impl, duckchat-impl, network-protection-impl
Steps to test
./gradlew spotlessCheckpasses@color/transparentremoval is a no-op)UI changes
No UI changes
Note
Low Risk
Changes are limited to Android XML lint suppression and baseline updates; runtime behavior should be unaffected aside from removing an explicit transparent background in one layout.
Overview
Suppresses a set of false-positive Android lint
Overdrawwarnings across multiple modules by addingtools:ignore="Overdraw"on root views that intentionally set backgrounds (activities/fragments, list rows, popups, and other UI containers).Updates each module’s
lint-baseline.xmlto drop the correspondingOverdrawentries, and removes an unnecessary@color/transparentroot background fromactivity_serp_easter_egg_logo.xml.Written by Cursor Bugbot for commit db6cb92. This will update automatically on new commits. Configure here.