Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: /
Description
Optimize when-clauses by removing cases that can never happen (sealed classes - else cases as well as java - null interop type)
Steps to test this PR
UI changes
None
Note
Low Risk
Low risk cleanup to make
whenexpressions exhaustive and remove dead/default branches; behavior should be unchanged aside from always acknowledging processed commands in Autofill screens.Overview
Cleans up multiple
whenstatements (design system, Autofill, VPN exclusions, PIR state handlers, subscriptions feedback, and GradleModuleType) by removing unreachableelse/no-op branches and relying on Kotlin exhaustiveness.In Autofill command handling (
AutofillManagementActivityandAutofillManagementCredentialsMode), the processed-command logging andviewModel.commandProcessedcall are now unconditional after thewhen, aligning with the assumption that commands are fully covered.Written by Cursor Bugbot for commit fbb3a28. This will update automatically on new commits. Configure here.