Fix save/load encoding mismatch#2
Open
didgogns wants to merge 1 commit into
Open
Conversation
…tely The save() function encodes with btoa(unescape(encodeURIComponent(...))), but load() was decoding with only JSON.parse(atob(...)), missing the reverse decodeURIComponent(escape(...)) step. This caused non-ASCII characters (like the × in the giftcode hunter multiplier message) to corrupt and double in size on every page load, producing garbled ÃÂÃÂ... strings that grew indefinitely. The fix adds decodeURIComponent(escape(...)) to match the save encoding, consistent with how loadOptions() already correctly handles this. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The save() function encodes with btoa(unescape(encodeURIComponent(...))), but load() was decoding with only JSON.parse(atob(...)), missing the reverse decodeURIComponent(escape(...)) step. This caused non-ASCII characters (like the × in the giftcode hunter multiplier message) to corrupt and double in size on every page load, producing garbled ÃÂÃÂ... strings that grew indefinitely.
The fix adds decodeURIComponent(escape(...)) to match the save encoding, consistent with how loadOptions() already correctly handles this.