This repository was archived by the owner on Sep 9, 2022. It is now read-only.
Open
Conversation
dtan4
suggested changes
Apr 21, 2019
Owner
dtan4
left a comment
dtan4
left a comment
There was a problem hiding this comment.
Sorry for the late review 🙇
- Could you add changes in tfstate? I think Terraform will show diff unless tfstate is updated.
- Could you add a testcase about to generate the additional fields?
Author
|
Sure. Let me update it in the weekend. |
linc01n
force-pushed
the
add-load-balancer-to-asg
branch
from
4234be1 to
d92a562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.