Skip to content

fix: add 6 missing Cairo-area cities to Egypt dataset#1370

Merged
dr5hn merged 1 commit intomasterfrom
fix/1331-egypt-cairo
Mar 28, 2026
Merged

fix: add 6 missing Cairo-area cities to Egypt dataset#1370
dr5hn merged 1 commit intomasterfrom
fix/1331-egypt-cairo

Conversation

@dr5hn
Copy link
Copy Markdown
Owner

@dr5hn dr5hn commented Mar 28, 2026

Rebased version of #1331 (data-only, no BQ.json/countries.json/schema.sql contamination). Adds 6 Cairo-area cities. Closes #1331

Adds: Nasr City, Cairo Downtown, Zamalek, Rehab, Obour City, New Cairo.

Closes #1331

Co-Authored-By: copilot-swe-agent[bot] <[email protected]>
@dr5hn dr5hn merged commit e28e633 into master Mar 28, 2026
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 28, 2026
@dr5hn dr5hn deleted the fix/1331-egypt-cairo branch March 28, 2026 09:51
@github-actions
Copy link
Copy Markdown
Contributor

CSC Validation Report

PR Format

  • ✅ Description provided
  • ❌ Data source linked
  • ✅ Issue linked (recommended for data changes)
  • ✅ Justification / context provided

Labels applied: data:cities

Schema Validation (163 records)

Errors (blocking):

  • ❌ contributions/cities/EG.json: Record 1 ("Abnūb"): "id" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 1 ("Abnūb"): "created_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 1 ("Abnūb"): "updated_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 1 ("Abnūb"): "flag" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 2 ("Abu Simbel"): "id" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 2 ("Abu Simbel"): "created_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 2 ("Abu Simbel"): "updated_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 2 ("Abu Simbel"): "flag" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 3 ("Abū Qurqāş"): "id" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 3 ("Abū Qurqāş"): "created_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 3 ("Abū Qurqāş"): "updated_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 3 ("Abū Qurqāş"): "flag" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 4 ("Abū Tīj"): "id" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 4 ("Abū Tīj"): "created_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 4 ("Abū Tīj"): "updated_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 4 ("Abū Tīj"): "flag" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 5 ("Abū al Maţāmīr"): "id" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 5 ("Abū al Maţāmīr"): "created_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 5 ("Abū al Maţāmīr"): "updated_at" must not be included (auto-managed)
  • ❌ contributions/cities/EG.json: Record 5 ("Abū al Maţāmīr"): "flag" must not be included (auto-managed)
  • ...and 632 more errors

Warnings:

  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb"): unknown field "type"
  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb"): unknown field "level"
  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb"): unknown field "parent_id"
  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb"): unknown field "native"
  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb"): unknown field "population"
  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb"): unknown field "translations"
  • ⚠️ contributions/cities/EG.json: Record 2 ("Abu Simbel"): unknown field "type"
  • ⚠️ contributions/cities/EG.json: Record 2 ("Abu Simbel"): unknown field "level"
  • ⚠️ contributions/cities/EG.json: Record 2 ("Abu Simbel"): unknown field "parent_id"
  • ⚠️ contributions/cities/EG.json: Record 2 ("Abu Simbel"): unknown field "native"
  • ...and 968 more warnings

Cross-Reference Validation

✅ 326 reference(s) verified

Geo-Bounds Check

✅ All 163 coordinate(s) within expected country bounds

Duplicate Detection

  • ⚠️ contributions/cities/EG.json: Record 1 ("Abnūb") appears to be a duplicate of existing "Abnūb" (id: 31755, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 2 ("Abu Simbel") appears to be a duplicate of existing "Abu Simbel" (id: 31756, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 3 ("Abū Qurqāş") appears to be a duplicate of existing "Abū Qurqāş" (id: 31757, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 4 ("Abū Tīj") appears to be a duplicate of existing "Abū Tīj" (id: 31758, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 5 ("Abū al Maţāmīr") appears to be a duplicate of existing "Abū al Maţāmīr" (id: 31759, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 6 ("Ad Dilinjāt") appears to be a duplicate of existing "Ad Dilinjāt" (id: 31760, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 7 ("Ain Sukhna") appears to be a duplicate of existing "Ain Sukhna" (id: 31761, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 8 ("Ajā") appears to be a duplicate of existing "Ajā" (id: 31762, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 9 ("Akhmīm") appears to be a duplicate of existing "Akhmīm" (id: 31763, distance: 0.0km)
  • ⚠️ contributions/cities/EG.json: Record 10 ("Al Badārī") appears to be a duplicate of existing "Al Badārī" (id: 31764, distance: 0.0km)

652 error(s), 1141 warning(s) | Status: Changes required

Please fix the errors above and push a new commit. Refer to our Contribution Guidelines for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:cities needs-changes size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant