Skip to content

fix: correct chain indexing so _atom_site.label_asym_id starts at 'A'#145

Merged
douweschulte merged 1 commit intodouweschulte:masterfrom
NessimRaou:master
Feb 16, 2026
Merged

fix: correct chain indexing so _atom_site.label_asym_id starts at 'A'#145
douweschulte merged 1 commit intodouweschulte:masterfrom
NessimRaou:master

Conversation

@NessimRaou
Copy link
Copy Markdown
Contributor

Fixed a bug when saving pdb as mmCIF where label indexing was offset:

  • Issue: chain_index was incremented at the start of the loop, causing the first chain being assigned index 1 (label_asym_id 'B')
  • Fix: increment chain_index at the end of the loop so label_asym_id correctly starts at 'A' while keeping label_entity_id starting at 1

@douweschulte
Copy link
Copy Markdown
Owner

The changes look good, thanks for opening the PR. The failures are because of a renamed dependency and I will fix that outside of this PR.

@douweschulte douweschulte merged commit aab903c into douweschulte:master Feb 16, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants