fix: correct chain indexing so _atom_site.label_asym_id starts at 'A'#145
Merged
douweschulte merged 1 commit intodouweschulte:masterfrom Feb 16, 2026
Merged
fix: correct chain indexing so _atom_site.label_asym_id starts at 'A'#145douweschulte merged 1 commit intodouweschulte:masterfrom
douweschulte merged 1 commit intodouweschulte:masterfrom
Conversation
Owner
|
The changes look good, thanks for opening the PR. The failures are because of a renamed dependency and I will fix that outside of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug when saving pdb as mmCIF where label indexing was offset:
chain_indexwas incremented at the start of the loop, causing the first chain being assigned index 1 (label_asym_id 'B')chain_indexat the end of the loop solabel_asym_idcorrectly starts at 'A' while keepinglabel_entity_idstarting at 1