enkimi is now able to be used as a subdirectory in a cmake project, example now copies dependencies into binary directory #2
Open
Cazadorro wants to merge 1 commit intodougbinks:masterfrom
Conversation
…target, how also has an alias target, can be used as a subdirectory, added ability to conditionally include build files for executable example, example target now exists as enkimi_example, and now copies its .mca runtime dependency as part of the build process using CMake, allowing it to execute with out user taking into consideration where the source is.
Owner
|
Thanks for the PR, I'll take a look at this soon. Given enkiMI is only 2 source files with no complex options I'd not considered a cmake project to be of much use other than to be able to quickly build the example. Since it's useful to you (and so perhaps others) I will look into merging this, but I will make changes as for simple projects I prefer only one cmakelists.txt in the root directory to keep the source and example directories 'clean'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enkiMI target is now able to be used independently of the executable target, how also has an alias target, can be used as a subdirectory, added ability to conditionally include build files for executable example, example target now exists as enkimi_example, and now copies its .mca runtime dependency as part of the build process using CMake, allowing it to execute with out user taking into consideration where the source is.
With out these changes, using this project as a library would not have been able to be used as a subdirectory in cmake, and building the example would not have been possible with out the copying of its runtime dependencies.