Support Python 3.14 (without changes to github actions)#238
Support Python 3.14 (without changes to github actions)#238robinvandernoord wants to merge 1 commit intodottxt-ai:mainfrom
Conversation
…4, add type hint required to compile with new versions
|
@RobinPicard is there any chance we can get some maintainer attention here? It'd be nice to make sure the |
|
Hi @ngoldbaum! Yes, I was looking at it today actually. I tried running the tests on the branch of #235 and everything worked. I wanted to rebase and push, but I don't have the permissions to do so. Could you let me push commits on your branch @robinvandernoord please? |
|
@RobinPicard thanks for looking into it! I've invited you with write access to the fork. If you need anything else, please let me know! |
|
Closing the PR as #235 has been merged. Thanks @robinvandernoord and @ngoldbaum! |
As suggested by @ngoldbaum in #235, I'm recreating a PR for the Python 3.14 fix without the changes in the
.github/workflows/build_wheels.ymlfile.This because while outlines-core works on 3.14 with the updated dependencies, not all tests pass yet due to dependencies (numba, torch) that are not yet compatible. I've attached the description of my original PR for reference:
I've updated the required dependencies (pyo3 and serde-pyobject) to versions that support Python 3.14.
This caused a compilation error when building, which I've fixed in
src/python_bindings/mod.rsby adding a type hint.Furthermore, I've added 3.14 as a build target in thebuild_wheels.ymlgithub workflow.Running
make teststill failed on 4 tests:This is due to numba not supporting 3.14 and torch only partially supporting it.