Skip to content

Add failing ILTrim tests to baseline#126923

Merged
MichalStrehovsky merged 2 commits intodotnet:mainfrom
sbomer:fix-iltrim-tests
Apr 15, 2026
Merged

Add failing ILTrim tests to baseline#126923
MichalStrehovsky merged 2 commits intodotnet:mainfrom
sbomer:fix-iltrim-tests

Conversation

@sbomer
Copy link
Copy Markdown
Member

@sbomer sbomer commented Apr 14, 2026

Failing in main, hit in #123040.

@dotnet-policy-service
Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib
See info in area-owners.md if you want to be subscribed.

Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird, we did run the ILTrim tests on that PR and the results were only 5 days old:

2026-04-09T23:08:38.7818259Z Running tests: /__w/1/s/artifacts/bin/ILTrim.Tests/x64/Checked/ILTrim.Tests.dll [net11.0|x64]
2026-04-09T23:10:17.8033735Z Tests succeeded: /__w/1/s/artifacts/bin/ILTrim.Tests/x64/Checked/ILTrim.Tests.dll [net11.0|x64]

Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wait, where is the list of failing tests coming from?

Pulling down the logs from https://dev.azure.com/dnceng-public/public/_build/results?buildId=1378629&view=artifacts&pathAsName=false&type=publishedArtifacts:

Test Run Failed.
Total tests: 912
Passed: 286
Failed: 1
Skipped: 625
Total time: 1.7779 Minutes

  Failed Generics.GenericConstraints [47 ms]
  Error Message:
   Assert.Fail failed. Type `System.Runtime.CompilerServices.IsUnmanagedAttribute' should have been kept
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraint/TestClass::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraint/TestClass::.cctor()' should have been removed
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraintOnMethod/TestClass::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/NewConstraintOnMethod/TestClass::.cctor()' should have been removed
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/StructConstraint/TestStruct::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/StructConstraint/TestStruct::.cctor()' should have been removed
Field `System.Int32 Mono.Linker.Tests.Cases.Generics.GenericConstraints/UnmanagedConstraint/TestStruct::field' should have been removed
Method `System.Void Mono.Linker.Tests.Cases.Generics.GenericConstraints/UnmanagedConstraint/TestStruct::.cctor()' should have been removed
Missing custom attributes on `generic parameter 'T' of Mono.Linker.Tests.Cases.Generics.GenericConstraints/UnmanagedConstraint/WithConstraint`1`:
    System.Runtime.CompilerServices.IsUnmanagedAttribute

That one looks expected.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Removed several unused attributes and warnings from expected failures list.
@MichalStrehovsky
Copy link
Copy Markdown
Member

Oh, wait, where is the list of failing tests coming from?

The CI was failing because we also check the tests in ExpectedFailures are actually failing and they were not. Updated it to just the one test, we'll see.

@sbomer
Copy link
Copy Markdown
Member Author

sbomer commented Apr 15, 2026

where is the list of failing tests coming from?

Ah, thanks - my original list was failing locally due to missing ilasm, but that was unrelated to the ci failure.

@MichalStrehovsky
Copy link
Copy Markdown
Member

/ba-g remaining legs are on track to time out and they are not interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants