[WIP][Revert][Android] Fix CollectionView inside disabled RefreshView blocks scroll#36715
Draft
SyedAbdulAzeemSF4852 wants to merge 2 commits into
Draft
Conversation
SyedAbdulAzeemSF4852
had a problem deploying
to
copilot-pat-pool
July 22, 2026 07:07 — with
GitHub Actions
Failure
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 36715Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 36715" |
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Hey there @@SyedAbdulAzeemSF4852! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
Reason
IsEnabled cascading from parent to child is expected, by-design behavior — VisualElement.IsEnabledCore (src/Controls/src/Core/VisualElement/VisualElement.cs) coerces a child's IsEnabled to false whenever any ancestor is disabled.
Issue #34666 was filed with an "Expected Behavior" of "Page C6 can scroll" — but the C6 manual test's own written pass-criteria only checks that the refresh spinner does not appear; it never specifies that the CollectionView must remain scrollable. The reporter's expectation goes beyond what C6 actually tests for, and contradicts IsEnabled 's cascading behavior (per IsEnabledCore) — the correct API for "block only the refresh gesture, keep content interactive" is RefreshView.IsRefreshEnabled = false , not IsEnabled = false .
Changes
Issues Fixed
Relates to #34666 — the underlying report is describing IsEnabled 's expected, by-design cascading behavior, not a bug; the correct fix for the reporter's actual use case is IsRefreshEnabled = false , not IsEnabled = false.