Add QUERY to known HTTP methods in HostingMetrics#63276
Open
doominator42 wants to merge 1 commit intodotnet:mainfrom
Open
Add QUERY to known HTTP methods in HostingMetrics#63276doominator42 wants to merge 1 commit intodotnet:mainfrom
doominator42 wants to merge 1 commit intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
added
the
community-contribution
| KeyValuePair.Create(HttpMethods.Patch, HttpMethods.Patch), | ||
| KeyValuePair.Create(HttpMethods.Post, HttpMethods.Post), | ||
| KeyValuePair.Create(HttpMethods.Put, HttpMethods.Put), | ||
| KeyValuePair.Create(HttpMethods.Query, HttpMethods.Query), |
Contributor
|
It looks like based on the linked discussion we need to put this in a holding pattern until the discussion in #62090 (review) is resolved. |
dotnet-policy-service
bot
added
the
pending-ci-rerun
Author
|
#62090 is now merged, I rebased my branch on top of it. For the OTEL semantics, according to open-telemetry/semantic-conventions#2642 (comment), adding methods known to the instrumentation is ok and since QUERY is now supported it would still follow conventions. Also, I did not find any tests specific to the known HTTP methods, should I just add new ones or this is good to go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #61089 (comment), this PR is for adding
QUERYto the known HTTP methods for hosting metrics.