Fix ValidIdentifierHelper.IsValidIdentifier accepting @ as valid#2040
Open
SimonCropp wants to merge 2 commits intodotnet:mainfrom
Open
Fix ValidIdentifierHelper.IsValidIdentifier accepting @ as valid#2040SimonCropp wants to merge 2 commits intodotnet:mainfrom
SimonCropp wants to merge 2 commits intodotnet:mainfrom
Conversation
The else branch stripped the '@' prefix via Substring(1) but never validated the remaining value, so "@" alone was accepted as a valid identifier. Add an empty check after stripping and add tests.
mikeebowen
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The else branch stripped the '@' prefix via Substring(1) but never validated the remaining value, so "@" alone was accepted as a valid identifier. Add an empty check after stripping and add tests.