Optimize, simplify FromChunkedBase64String method#1868
Merged
twsouthwick merged 2 commits intodotnet:mainfrom Mar 10, 2025
Merged
Conversation
… and lower memory usage
Test Results 70 files 70 suites 1h 7m 48s ⏱️ Results for commit bee9325. ♻️ This comment has been updated with latest results. |
lindexi
reviewed
Feb 27, 2025
| return Cached.Array<byte>(); | ||
| } | ||
|
|
||
| var base64CharArray = chunkedBase64String.Where(c => c is not '\r' and not '\n').ToArray(); |
Member
There was a problem hiding this comment.
Can you sure the chunkedBase64String much not include the \r or \n char?
Contributor
Author
There was a problem hiding this comment.
Hi @lindexi. Yes, I am sure \r and \n will be removed automatically.
This is source code of the method in dotnet runtime:
mikeebowen
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update optimizes and simplifies the FromChunkedBase64String method, improving both performance and memory efficiency.
Implementation Details
Removed unnecessary manual handling of \r and \n, as Convert.FromBase64String already handles these characters automatically.
Eliminated Where() and ToArray() operations, significantly reducing memory allocations and improving execution efficiency.
Benchmark Results
Performance: ~2.4x speed improvement
Memory Usage: ~70% reduction