Bump inquirer and improve related tests#10651
Merged
eddeee888 merged 7 commits intomaster-nextfrom Mar 22, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 14d2207 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/core |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/add |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/fragment-matcher |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/introspection |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/schema-ast |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/time |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/visitor-plugin-common |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
6.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/testing |
5.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/plugin-helpers |
7.0.0-alpha-20260322132510-14d22072d7f8a2b88050538ae695ec8c3a7b4bce |
npm ↗︎ unpkg ↗︎ |
eddeee888
commented
Mar 22, 2026
| @@ -1,5 +1,5 @@ | |||
| import { resolve } from 'path'; | |||
| import bddStdin from 'bdd-stdin'; | |||
| import { screen } from '@inquirer/testing/vitest'; | |||
Collaborator
Author
There was a problem hiding this comment.
@inquirer/testing allows us to test exactly what's shown in the terminal, which is nicer than bdd-stdin!
Furthermore, with bdd-stdin, we need custom "typing" and "key press" mapping.
eddeee888
commented
Mar 22, 2026
| it('should guess vue projects', () => { | ||
| vol.fromJSON({ ['package.json']: packageJson.withVue }, process.cwd()); | ||
| const targets = await guessTargets(); | ||
| const targets = guessTargets(); |
Collaborator
Author
There was a problem hiding this comment.
guessTargets is now sync (it never needed to be async)
eddeee888
commented
Mar 22, 2026
| generates: { | ||
| "src/gql/": { | ||
| preset: "client", | ||
| plugins: [] |
Collaborator
Author
There was a problem hiding this comment.
plugins is not needed when setting up this client preset. I'll come back in another PR to fix it.
eddeee888
commented
Mar 22, 2026
| "devDependencies": { | ||
| "@graphql-codegen/cli": "1.0.0", | ||
| "@graphql-codegen/typescript": "1.0.0", | ||
| "@graphql-codegen/typescript-operations": "1.0.0", |
Collaborator
Author
There was a problem hiding this comment.
I'm unfamiliar with the stencil plugin requirements...
But most likely we won't need typescript? 🤔
Will check and fix in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR bumps
@inquirer/promptsfrom v7 to v8 in@graphql/condegen/clipackage and fixes testsRelated #10496