refactor(desktop): move iCloud to Cloud sub-option in sync settings#332
Merged
dongdongbh merged 1 commit intodongdongbh:mainfrom Mar 30, 2026
Merged
Conversation
Moves the iCloud sync button from a top-level backend option to a
sub-option under the Cloud backend, alongside Self-Hosted and Dropbox.
Renames the top-level button from "Self-Hosted" to "Cloud" since it
now groups multiple cloud providers.
- Set cloudProvider before syncBackend to avoid race where a sync
cycle starts with the old provider value
- Only call onSetSyncBackend when actually switching backends (skip
when already on 'cloud')
- Add iCloud info panel ("No setup required") so the UI isn't empty
when cloudkit is selected
- No sync-service changes — cloudkit remains its own SyncBackend value
internally; only the UI grouping changes
Co-Authored-By: Claude Opus 4.6 <[email protected]>
joshuaferris
force-pushed
the
ui/icloud-settings-button
branch
from
7bc9e0b to
267f9e5
Compare
dongdongbh
approved these changes
Mar 30, 2026
Owner
dongdongbh
left a comment
dongdongbh
left a comment
There was a problem hiding this comment.
Ready to merge
- The UI regrouping is directionally right and keeps sync choices simpler at the top level.
- I rechecked the desktop settings path locally and the cloud/cloudkit selection logic looks consistent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloudkitremains its ownSyncBackendvalue internallySplit out from #326 per review feedback. This is a pure UI cleanup with no native code changes.
Test plan
cloudorcloudkitcloudkit; selecting Self-Hosted/Dropbox sets backend tocloud🤖 Generated with Claude Code