allow querying column or sql value with star expr and add client tests#2855
Conversation
|
|
SummaryThe run covered database client compatibility across multiple languages, including normal query workflows, rebuild stability checks, and dependency drift behavior, and most happy-path flows remained stable. It also exercised adversarial input and failure-path behavior, where newly changed connection and reactive execution paths showed serious safety and consistency regressions. Not safe to merge yet — this PR appears to introduce multiple high-severity failures in changed code paths, including security-sensitive input handling and non-atomic failure behavior that can leave inconsistent state. A separate medium-severity parallel test setup issue appears pre-existing and is a caveat, but the newly introduced high-severity defects are the merge blocker. Tests run by ItoAdditional Findings DetailsThese findings are unrelated to the current changes but were observed during testing. 🟡 Parallel CI jobs can select the same client-test port and one server fails to bind
Evidence PackageTip Reply with @itoqa to send us feedback on this test run. |
Footnotes
|
|
Diff SummaryThis diff run surfaced Coverage spanned end-to-end database client behavior across multiple language paths, including normal workflows, rebuild/regression stability checks, and edge-case handling like malformed inputs and mid-flow failures. Overall behavior is mostly stable on core happy paths, but some failure-handling and input-validation paths still produce inconsistent or brittle outcomes. Merge with caution — this PR introduces medium-severity reliability issues in newly added client-flow code, specifically around graceful input handling and state safety when a sequence fails partway through. Several other failures were also observed but are marked as pre-existing, so they are important backlog risk rather than direct blockers from this change. Tests run by ItoAdditional Findings DetailsThese findings are unrelated to the current changes but were observed during testing. 🟡 Postgrex client hits internal server error
Evidence PackageTip Reply with @itoqa to send us feedback on this test run. |
|
Diff SummaryThis diff run surfaced This run covered end-to-end database client behavior across multiple language runtimes, including normal query flows, build/runtime packaging checks, and failure handling during state-changing workflows. It also exercised edge and abuse-style conditions like malformed connection input, concurrent runs, and immediate retries to assess reliability under stress. Merge with caution — the PR appears to introduce medium-severity reliability problems in the new Swift workflow, where concurrent execution and retry behavior can produce inconsistent or contaminated state. There are also several high-severity failures elsewhere, but those were identified as pre-existing and are caveats rather than merge blockers for this specific change. Tests run by ItoTip Reply with @itoqa to send us feedback on this test run. |
|
Diff SummaryThis diff run surfaced This run exercised broad database behavior across normal client workflows, input-hardening edge cases, retry and fault handling, configuration/runtime paths, and data-type conversion and query-filter correctness. Most areas were stable, but a concentrated weakness appeared in new tuple-comparison filtering behavior where less-than logic regressed. Not safe to merge yet — the PR introduces a high-severity regression in query predicate handling, with an additional related medium issue in the same changed area, indicating real risk of incorrect query behavior in production. A separate high-severity client-protocol failure was observed but appears pre-existing, so the merge block is the newly introduced predicate logic defects. Tests run by ItoTip Reply with @itoqa to send us feedback on this test run. |


No description provided.