Add support for UTF8 chars in identifiers#2588
Merged
Conversation
Contributor
|
zachmu
approved these changes
Apr 14, 2026
| // including supplementary Unicode (emoji, code points above U+FFFF) unlike MySQL. | ||
| // https://www.postgresql.org/docs/current/sql-syntax-lexical.html | ||
| func IsValidPostgresIdentifier(name string) bool { | ||
| if len(name) == 0 { |
Member
There was a problem hiding this comment.
Are there length limits? Are they enforced elsewhere?
Contributor
Author
There was a problem hiding this comment.
There is a 63 byte limit... but... the docs say that Postgres will automatically truncate longer identifiers to that limit, so we do have some work to do that truncation, but I don't think we want to return false here and reject them outright.
Contributor
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables use of UTF8 chars in identifiers, matching PostgreSQL behavior.
Related to #2580