Open
Conversation
Contributor
|
6933080 to
ea1ca1d
Compare
ea1ca1d to
af3fa73
Compare
Contributor
Footnotes
|
Collaborator
Author
|
Performance metrics are likely impacted by the lack of context threading, which is triggering a full collection build every time. That will be fixed once I’ve finished threading the context everywhere in GMS. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes casts from being strictly built-in functionality to now being a root object collection, which will allow for users to be able to use
CREATE CAST.With this PR, there are two major pieces of work that still need to be done.
*sql.Contexteverywhere in GMS.sql.Nodefunctions such asWithChildrendo not currently take a context, and we've tried to hack around this for too long by storing contexts inside of the struct itself, but that can only go so far. For now, I have a hack that creates a faux collection in the presence of a nil context, and that collection only allows access to the built-in casts.