Open
Conversation
devpaul
reviewed
Aug 28, 2017
| const tmpDir = mkdtempSync('.test/dir-'); | ||
|
|
||
| if (ext) { | ||
| return join(tmpDir, `index${ext}`); |
Member
There was a problem hiding this comment.
I understand why this was done because sometimes we want a filename. But it doesn't really follow that by passing an extension that it should make a temp directory and join it with a filename index${ext}. I would just move the join outside of this function to explicitly call out what's going on.
devpaul
suggested changes
Aug 28, 2017
| export const suites = [ 'tests/unit/all' ]; | ||
|
|
||
| export const excludeInstrumentation = /^(?:_build\/tests|node_modules)\//; | ||
| export const excludeInstrumentation = true; // /^(?:_build\/tests|node_modules)\//; |
Member
There was a problem hiding this comment.
I'm not sure why we excluded instrumentation here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will resolve #12.
Per that ticket the following tests have been added:
externalPatternandexcludeExternalsoptions
excludeoptionincludeDeclarationsoption