Handle document relation compatibility#23
Open
paulinevos wants to merge 2 commits intodoctrine:0.1.xfrom
Open
Conversation
`Reference*` relationships cannot target `EmbeddedDocument`s and vice-versa for standalone `Document`s. This commit adds checks for compatibility and offers to change the document type (if possible).
When a document is generated with `make:document`, it now offers the
paulinevos
force-pushed
the
validate-relations
branch
from
fa067bc to
05308f3
Compare
GromNaN
reviewed
Mar 18, 2026
| $metadata = $this->registry->getManager()->getClassMetadata($className); | ||
|
|
||
| if ($metadata === null) { | ||
| throw new RuntimeException($className . '" is not a valid document.'); |
Member
There was a problem hiding this comment.
Opening quote is missing.
Suggested change
| throw new RuntimeException($className . '" is not a valid document.'); | |
| throw new RuntimeException(sprintf('"%s" is not a valid document.', $className)); |
|
|
||
| use function sprintf; | ||
|
|
||
| final class IncompatibleParentRelationException extends Exception |
Member
There was a problem hiding this comment.
I would disable this phpcs rule. Having an exception class that does not end with ...Exception is unconventional.
| parent::__construct($message); | ||
| } | ||
|
|
||
| public static function forEmbeddingParents(string $className, string ...$parents): self |
Member
There was a problem hiding this comment.
The factory methods should be @internal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helper test still failing because of metadata cache -- will try to fix that tomorrow.