Skip to content

Fix task deploy-local#2024

Merged
dgageot merged 1 commit intodocker:mainfrom
dgageot:fix-deploy-local
Mar 10, 2026
Merged

Fix task deploy-local#2024
dgageot merged 1 commit intodocker:mainfrom
dgageot:fix-deploy-local

Conversation

@dgageot
Copy link
Member

@dgageot dgageot commented Mar 10, 2026

Sometimes, docker agent wouldn't work after running task deploy-local and the docker-agent plugin looked corrupted

Signed-off-by: David Gageot <david.gageot@docker.com>
@dgageot dgageot requested a review from a team as a code owner March 10, 2026 08:43
Copy link

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Assessment: 🟢 APPROVE

This change improves the deploy-local task by replacing a file copy with a symlink. The modification ensures that ~/.docker/cli-plugins/docker-agent always points to the latest build in the project directory, preventing the corruption issues mentioned in the PR description.

Key improvements:

  • Uses symlink (ln -sf) instead of copy (cp -P) to link the CLI plugin
  • Ensures changes are immediately reflected without re-running deploy-local
  • Properly uses Task variables ({{.TASKFILE_DIR}} and {{.HOME}})
  • Forces symlink creation with -sf flags to handle existing files

✅ No bugs or issues detected in the changed code.

@dgageot dgageot merged commit 4c1aefb into docker:main Mar 10, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants