fix(publish): honor env_file required: false for missing files#13848
Open
Ijtihed wants to merge 1 commit into
Open
fix(publish): honor env_file required: false for missing files#13848Ijtihed wants to merge 1 commit into
Ijtihed wants to merge 1 commit into
Conversation
Signed-off-by: Ijtihed Kilani <ijtihedk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When env_file declares required false and the file is missing then docker compose publish now skips the file instead of failing. If the optional file exists it is still scanned for sensitive data and included as a layer which preserves existing behavior.
Two locations needed guards:
Non-ENOENT errors (permissions, etc.) still propagate regardless of the required flag.
Related issue
Fixes #13648
Supersedes #13650, #13651, #13652 with a diff implementing what the maintainers request in #13652 review
(unrelated photo of my fiance's cute cat :3)