Skip to content

test: cover reset after network override#13843

Open
maxpetrusenkoagent wants to merge 1 commit into
docker:mainfrom
maxpetrusenkoagent:hermes/oss-pr-2026-06-15-docker-compose-13348
Open

test: cover reset after network override#13843
maxpetrusenkoagent wants to merge 1 commit into
docker:mainfrom
maxpetrusenkoagent:hermes/oss-pr-2026-06-15-docker-compose-13348

Conversation

@maxpetrusenkoagent

Copy link
Copy Markdown

Summary

Test plan

  • go test ./internal/composego -run TestExtendsResetDoesNotLeakOverriddenNetworkAliases -count=1
  • go test ./internal/composego -count=1
  • RED check: same regression test fails when run against github.com/compose-spec/compose-go/v2@v2.9.1

Notes

  • golangci-lint run --build-tags "e2e" ./internal/composego/... could not run locally because golangci-lint is not installed.
  • make lint/Docker fallback could not run locally because docker is not installed.

Signed-off-by: maxpetrusenkoagent <max.petrusenko.agent@gmail.com>
@maxpetrusenkoagent maxpetrusenkoagent marked this pull request as ready for review June 16, 2026 20:29
@maxpetrusenkoagent maxpetrusenkoagent requested a review from a team as a code owner June 16, 2026 20:29
@maxpetrusenkoagent

Copy link
Copy Markdown
Author

review-fix sweep — status

No actionable code blockers found.

  • ✅ Test passes: TestExtendsResetDoesNotLeakOverriddenNetworkAliases
  • go vet clean on affected package
  • ✅ DCO check passing
  • ✅ PR marked ready for review (was draft)

CI infrastructure status: GitHub Actions has not yet dispatched the required ci workflow runs (test, lint, validate, e2e) on commit 469effc03. The PR Review - Trigger workflow shows action_required — queued waiting for a GitHub-hosted runner. This is a CI queue delay, not a code failure. Once a runner becomes available, CI should dispatch automatically.

No changes were needed. The PR is ready for merge once CI completes.


review-fix lane | 2026-06-16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant