feat(convert): set default model and endpoint variables for services in convert.go - #13342
Closed
idsulik wants to merge 2 commits into
Closed
feat(convert): set default model and endpoint variables for services in convert.go#13342idsulik wants to merge 2 commits into
idsulik wants to merge 2 commits into
Conversation
…in convert.go Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com>
ndeloof
reviewed
Nov 3, 2025
ndeloof
left a comment
ndeloof
left a comment
Contributor
There was a problem hiding this comment.
default values should be set by compose-go as we load a project IMHO
Collaborator
Author
|
@ndeloof but I'm not sure if it ok to make these changes for all places, because the documentation says only about environment values https://docs.docker.com/reference/compose-file/services/#models
but in this PR I made the changes only for the converter, because it doesn't work even if you specify the environment values |
Contributor
|
closing as #13341 was fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
This PR resolves issue #13341 by automatically setting default
model_varandendpoint_varvalues for services that use models but don't explicitly define these variablesRelated issue
#13341