WIP: bump moby/client and moby/api#6893
Draft
thaJeztah wants to merge 4 commits intodocker:masterfrom
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Member
Author
|
Some failures may be legit; need to check if the tests were wrong (and something fixed) or if we have a regression cc @vvoland FYI |
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
Member
Author
|
Still some remaining failures; need to look at these; from what I can see, it's to allow a port-mapping without host-port specified ( #18 68.06 === Failed
#18 68.06 === FAIL: cli/command/service TestUpdatePorts (0.00s)
#18 68.06 update_test.go:282: assertion failed: expected [{ udp %!s(uint32=333) %!s(uint32=0) } { %!s(uint32=555) %!s(uint32=0) } { tcp %!s(uint32=1000) %!s(uint32=1000) ingress}] (length 3) to have length 2
#18 68.06
#18 68.06 === FAIL: cli/command/service TestUpdatePortsRmWithProtocol (0.00s)
#18 68.06 update_test.go:499: assertion failed: expected [{ tcp %!s(uint32=80) %!s(uint32=8080) ingress} { tcp %!s(uint32=81) %!s(uint32=8081) ingress} { tcp %!s(uint32=82) %!s(uint32=8082) ingress}] (length 3) to have length 2
#18 68.06
#18 68.06 === FAIL: cli/compose/loader TestFullExample (0.02s)
#18 68.06 loader_test.go:982: assertion failed: error is not nil: decoding failed due to the following error(s):
#18 68.06
#18 68.06 'Ports' invalid ranges specified for container and host Ports: 3001-3005 and 0
#18 68.06
#18 68.06 === FAIL: opts/swarmopts TestPortOptValidSimpleSyntax/80 (0.00s)
#18 68.06 port_test.go:147: assertion failed: expected [] (length 0) to have length 1
#18 68.06 port_test.go:149: expected [] to contain { tcp 80 0 ingress}, did not
#18 68.06
68.06 === FAIL: opts/swarmopts TestPortOptValidSimpleSyntax/80 (0.00s)
68.06 port_test.go:147: assertion failed: expected [] (length 0) to have length 1
68.06 port_test.go:149: expected [] to contain { tcp 80 0 ingress}, did not
68.06
68.06 === FAIL: opts/swarmopts TestPortOptValidSimpleSyntax (0.00s |
thaJeztah
commented
Apr 2, 2026
| return func(yield func(Port) bool) { | ||
| if pr.proto == protoZero { | ||
| return | ||
| } |
Member
Author
There was a problem hiding this comment.
This is the culprit; the zero value means "map to ephemeral port" so should not be discarded
This reverts commit ae9e27b. Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)