Dependency update kysely codegen - #7
Open
dsheng123 wants to merge 3 commits into
Open
Conversation
- current version results in peer dependency warnings for kysely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @dnlsandiego,
since kysely is indicating peer dependency warnings for newer kysely versions (28), I made this PR to update dependencies.
I ran pnpm scripts to ensure local code quality
pnpm test pnpm format pnpm typecheckI also used my version as a local package to verify code generation still works.
I am not sure about the current state of your repository, so please let me know if you see this PR even if your answer is that your repo will no longer be maintained.
In case you do merge this PR, it would be great if you could also publish a new version to npm!