Add elliptical rotation option to RotationTransform#1752
Open
mxbi wants to merge 1 commit intodmlc:masterfrom
Open
Add elliptical rotation option to RotationTransform#1752mxbi wants to merge 1 commit intodmlc:masterfrom
mxbi wants to merge 1 commit intodmlc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small extension to the
RotationTransformtransform for object detection; the user can choose to rotate bounding boxes by approximating the underlying object as an ellipsis rather than a rectangle. This solves a common problem with using rotations, where the bounding boxes are enlarged (this can significantly hurt performance).In the below image, the original bounding box is shown in red, the "normal" way of rotating the bounding box (current behaviour) is shown in blue. The elliptical method added by this PR is shown in green. As you can see, the rectangular boxes are significantly larger than the objects which the boxes are for.
Source code for the below image
This PR adds this feature by overloading
RotationTransform.apply_boxand adding a new parameterbox_method. The default behaviour is unchanged, but if the user setsbox_method='ellipsis'they will get the tighter elliptical boxes. This also passes the linter :)For reference: [Paper showing significant performance improvements] [Same feature in albumentations]