Skip to content

Fix PR update branch state#849

Open
cyphercodes wants to merge 2 commits into
dlvhdr:mainfrom
cyphercodes:fix/pr-update-branch-state-842
Open

Fix PR update branch state#849
cyphercodes wants to merge 2 commits into
dlvhdr:mainfrom
cyphercodes:fix/pr-update-branch-state-842

Conversation

@cyphercodes
Copy link
Copy Markdown

Summary

Prevent the pr update-branch task from marking the PR as closed in the follow-up UI update message. Branch updates now leave the open/closed state unchanged; close/reopen/merge actions still update that state explicitly.

How Did You Test this Change?

  • go test ./internal/tui/components/tasks
  • go test ./internal/tui/components/tasks ./internal/tui/components/prssection

Images/Videos

N/A

AI disclosure: This PR was prepared with AI assistance from Hermes Agent (OpenAI Codex). Assistance included issue/code inspection, implementing the small fix, adding tests, and running verification.

dlvhdr
dlvhdr previously approved these changes May 2, 2026
Copy link
Copy Markdown
Owner

@dlvhdr dlvhdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@cyphercodes
Copy link
Copy Markdown
Author

Updated this to fix the lint failure from golines by wrapping the long assertion in internal/tui/components/tasks/pr_test.go.

Local verification:

  • go test ./internal/tui/components/tasks -run 'TestUpdatePR' -count=1
  • golangci-lint run ./internal/tui/components/tasks/...
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] u temporarily closes the PR during update from base branch

2 participants