Inline hasElaborateDestructor!(...) into __(needsDestruction, ...)#22853
Inline hasElaborateDestructor!(...) into __(needsDestruction, ...)#22853nordlow wants to merge 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @nordlow! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22853" |
thewilsonator
left a comment
There was a problem hiding this comment.
otherwise looks good.
| { | ||
| import core.memory : GC; | ||
| import core.internal.traits : hasIndirections, hasElaborateDestructor; | ||
| import core.internal.traits : hasIndirections; |
There was a problem hiding this comment.
this needs an update to compiler/test/compilable/vcg-ast.d, see e.g. the circleCI failure.
For the sake of avoiding template bloat as evaluation of a built trait is magnitudes faster than instantiating any template.
As mentioned in TODO at https://github.com/dlang/dmd/pull/22853/changes#diff-9cf671c1375bf050cf93c1ed0b4b81b30d5ba8822b10b9ef3435fc8f67e85553L289.