Skip to content

Fix slicing struct init array field with ArrayLiteralExpression.basis set#22807

Open
ntrel wants to merge 1 commit intodlang:masterfrom
ntrel:init-array-cmp
Open

Fix slicing struct init array field with ArrayLiteralExpression.basis set#22807
ntrel wants to merge 1 commit intodlang:masterfrom
ntrel:init-array-cmp

Conversation

@ntrel
Copy link
Copy Markdown
Contributor

@ntrel ntrel commented Mar 24, 2026

Fixes #22699.

Thanks to @oCHIKIo for finding the fix.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22807"

@ibuclaw
Copy link
Copy Markdown
Member

ibuclaw commented Mar 24, 2026

OK for targeting stable.

@oCHIKIo
Copy link
Copy Markdown
Contributor

oCHIKIo commented Mar 24, 2026

Thanks for putting the PR together @ntrel, glad I could help track down the fix! And thanks @ibuclaw for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slice of .init static array produces erroneous 'incompatible types for array comparison: E[] and E[]'

4 participants