Skip to content

Fix issue #21500 : [importc] undefined reference __Float32x4_t#22793

Open
thewilsonator wants to merge 1 commit intodlang:masterfrom
thewilsonator:importc-vector2
Open

Fix issue #21500 : [importc] undefined reference __Float32x4_t#22793
thewilsonator wants to merge 1 commit intodlang:masterfrom
thewilsonator:importc-vector2

Conversation

@thewilsonator
Copy link
Copy Markdown
Contributor

@thewilsonator thewilsonator commented Mar 23, 2026

TODO: tests

NB, this should fix the undefined identifier.
This does not address __attribute__ ((__aarch64_vector_pcs__)) which I presume would need to be a calling convention in LDC.

@thewilsonator thewilsonator requested a review from ibuclaw as a code owner March 23, 2026 01:10
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

  • In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#22793"

@kassane
Copy link
Copy Markdown
Contributor

kassane commented Mar 23, 2026

Please, check #21500 (comment)

@kinke
Copy link
Copy Markdown
Contributor

kinke commented Mar 23, 2026

This was already fixed (properly) in #21772:

version (CRuntime_Glibc) version (AArch64)
{
// math.h needs these
alias __Float32x4_t = __vector(float[4]);
alias __Float64x2_t = __vector(double[2]);
}

Copy link
Copy Markdown
Member

@ibuclaw ibuclaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants