fix(e2e): revert networkidle to domcontentloaded in a11y editor setup#29
Merged
Conversation
Gutenberg makes continuous background REST requests so networkidle never resolves, causing a 120s timeout. The existing toBeVisible timeout on the Block Inserter button is sufficient to wait for editor boot. The three other post-new.php navigations in this file already use domcontentloaded for the same reason. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 39 39
Lines 2416 2416
Branches 449 449
=======================================
Hits 1957 1957
Misses 113 113
Partials 346 346 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waitForLoadState('networkidle')to'domcontentloaded'at line 248 oftests/e2e/a11y.spec.jsnetworkidlenever resolves, causing the a11y test to time out at 120s every runtoBeVisible({ timeout: 30000 })on the Block Inserter button already waits for editor boot — no additional gate is neededpost-new.phpnavigations in this file already usedomcontentloadedfor the same reasonTest plan
Playwright Playground smoke / Run accessibility gatepasses🤖 Generated with Claude Code