Closed
Conversation
d368b3a to
6aa41c6
Compare
Contributor
Author
|
I looked at the code again, I think the main missing point compared to c++ thing is that it should take the input of the lexicon when looking for suggestions but the data structures are so well designed that I couldn't figure it out anymore. |
- Remove predictor functionality since it is unmaintained and non-functional - Organise API into what should be public - Merge analysis and speller traits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to work the way I was planning if acceptor.default.hfst in zhfst is replaced with analyser:
I had to comment out the trait for this experiment cause it didn't agree with multiple inheritance? Also other feedback will be useful :-)