Refactor ModerationService.cs to use IInfractionTypeHandler#1047
Open
NullEntity2 wants to merge 1 commit intodiscord-csharp:mainfrom
Open
Refactor ModerationService.cs to use IInfractionTypeHandler#1047NullEntity2 wants to merge 1 commit intodiscord-csharp:mainfrom
NullEntity2 wants to merge 1 commit intodiscord-csharp:mainfrom
Conversation
NullEntity2
force-pushed
the
moderation-refactor-2
branch
from
82b52f8 to
921065a
Compare
Author
|
I wasn't registering the types in DI - I thought it was automatic. I updated the commit to do that manually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change extracts the InfractionType logic into distinct classes to define their behavior. Mute, Notice, Warning, Ban each get their own class. This prevents the need to switch on types in multiple places within ModerationService. Importantly this will help with an addition I'm planning of a new InfractionType.
This CR was AI powered, but manually reviewed.