Add handling of threads to starboard#1046
Merged
patrickklaeren merged 4 commits intodiscord-csharp:mainfrom Oct 23, 2025
Merged
Add handling of threads to starboard#1046patrickklaeren merged 4 commits intodiscord-csharp:mainfrom
patrickklaeren merged 4 commits intodiscord-csharp:mainfrom
Conversation
- Exclude private thread channels always, as they are only visible to people who are mentioned in the thread - Exclude threads whose parent channel is ignored from the starboard - Doesn't remove existing messages on starboard that meet these requirements
- Not certain if this is strictly required, but probably a good idea to have in case it is
patrickklaeren
requested changes
Oct 23, 2025
patrickklaeren
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't tested this code. Please let me know if I need to do something relating to that.
Edit: not certain if we need null handling for
ParentChannel, I'd assumed it's not nullable since it wasn't marked as nullable, but it seems they don't have nullable annotations, so I'm not sure - I've added null handling in the second commit, I can remove it if we think it's not necessary.