Skip to content

fix: address eyebrow review feedback#224

Merged
LZylstra merged 3 commits intobry/block-eyebrowfrom
bry/fix-eyebrow-review-2
Mar 3, 2026
Merged

fix: address eyebrow review feedback#224
LZylstra merged 3 commits intobry/block-eyebrowfrom
bry/fix-eyebrow-review-2

Conversation

@MattatDirectus
Copy link
Copy Markdown
Contributor

What Changed

Addresses review
feedback on #220:

  • Replace hardcoded `#172940` with `var(--foreground)` for color and
    border
  • Replace hardcoded `#4ade80` with `--eyebrow-dot-color` CSS variable
    (defined on wrapper, overridable)
  • Wrap pulse animation in `@media (prefers-reduced-motion: no-preference)`

How to Test

  • Deploy preview:

Checklist

  • pnpm lint passes
  • pnpm typecheck passes
  • Verified changes in deploy preview

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 2, 2026

Deploy Preview for directus-website ready!

Name Link
🔨 Latest commit ea7f9a2
🔍 Latest deploy log https://app.netlify.com/projects/directus-website/deploys/69a5ff6947a7ae00088311be
😎 Deploy Preview https://deploy-preview-224--directus-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@LZylstra LZylstra changed the base branch from main to bry/block-eyebrow March 3, 2026 21:48
@LZylstra LZylstra merged commit b1bdaef into bry/block-eyebrow Mar 3, 2026
@LZylstra LZylstra deleted the bry/fix-eyebrow-review-2 branch March 3, 2026 22:21
MattatDirectus added a commit that referenced this pull request Mar 10, 2026
* feat: add block_eyebrow announcement pill component

* fix: address eyebrow review feedback (#224)

* fix: replace hardcoded colors with CSS vars, wrap animation in reduced-motion query

* Add BlockEyebrow to schema

---------

Co-authored-by: LZylstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants