Fix --nan-check false positive for finite/+INFINITY division#8745
Open
tautschnig wants to merge 1 commit intodiffblue:developfrom
Open
Fix --nan-check false positive for finite/+INFINITY division#8745tautschnig wants to merge 1 commit intodiffblue:developfrom
tautschnig wants to merge 1 commit intodiffblue:developfrom
Conversation
81bf5e7 to
4e48600
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8745 +/- ##
========================================
Coverage 80.00% 80.00%
========================================
Files 1700 1700
Lines 188254 188273 +19
Branches 73 73
========================================
+ Hits 150615 150631 +16
- Misses 37639 37642 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1ff0d85 to
1871271
Compare
- Update NaN check condition to require infinity in nominator
- Add regression tests to validate IEEE 754 infinity arithmetic
- Support __builtin_isfinite GCC built-in in C front-end
- Add __isfinite{,f,l} models of *BSD functions to C library
- Support fp.is{Negative,Positive} in the in-tree SMT2 solver
Fixes: diffblue#8634
1871271 to
5578125
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8634