refactor: extract accessibility code into dedicated modules#8486
Open
yuripourre wants to merge 2 commits intodiasurgical:masterfrom
Open
refactor: extract accessibility code into dedicated modules#8486yuripourre wants to merge 2 commits intodiasurgical:masterfrom
yuripourre wants to merge 2 commits intodiasurgical:masterfrom
Conversation
yuripourre
force-pushed
the
accessibility-prework
branch
4 times, most recently
from
2462066 to
96d5652
Compare
Add Source/accessibility/ with four new modules: - speech.cpp/hpp: low-HP warnings, durability warnings, boss/monster HP announcements, interactable door announcements - tracker.cpp/hpp: TrackerTargetCategory, path-finding predicates, tracker navigation (cycle, navigate, auto-walk) - town_navigation.cpp/hpp: town NPC selection, listing, auto-walk - location_speech.cpp/hpp: BFS path-finding for speech, player status announcements, nearest-exit/stairs/portal speech, keyboard walk Wire the new modules into diablo.cpp via four include lines. Declare CanPlayerTakeAction() and CancelAutoWalk() in diablo.h. Add the four new source files to Source/CMakeLists.txt.
yuripourre
force-pushed
the
accessibility-prework
branch
2 times, most recently
from
5368dbb to
b11ca43
Compare
yuripourre
force-pushed
the
accessibility-prework
branch
from
b11ca43 to
f62f809
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Source/accessibility/ with four new modules:
Wire the new modules into diablo.cpp via four include lines. Declare CanPlayerTakeAction() and CancelAutoWalk() in diablo.h. Add the four new source files to Source/CMakeLists.txt.