Visual Editor Performance Enhancements - #2598
Open
Jowan-Spooner wants to merge 12 commits into
Open
Conversation
This is very useful for testing and profiling the dialogic editor performance.
Also makes the debug optional and fixes some warnings
Collaborator
|
This thing still valid and need testing/updating @Jowan-Spooner ? |
Member
Author
|
Yeah most of this should still be valid just wildly outdated, so I might make a new PR, trying to port stuff from this again. |
1 similar comment
Member
Author
|
Yeah most of this should still be valid just wildly outdated, so I might make a new PR, trying to port stuff from this again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a bunch of experiments on my end to improve the performance of the visual editor loading times.
It's been a while since I did these, here is the main points I remember:
There is also an attempt at colored icons in here (for characters) but I scrapped it because unless we have a character color cache this would mean loading all the characters just to get their colors.
Testing and feedback would be very much appreciated.