feat: asset canister allows configuring fallback file and status#4515
Open
viviveevee wants to merge 4 commits intomasterfrom
Open
feat: asset canister allows configuring fallback file and status#4515viviveevee wants to merge 4 commits intomasterfrom
viviveevee wants to merge 4 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed support for asset certification v1.
Added customizable fallback behavior via the
configureendpoint. The newfallbackfield inConfigureArgumentsaccepts aFallbackConfiguration { path, status_code }to control which asset is served (and with which HTTP status) for requests that don't match any stored asset. Defaults to/index.htmlwith status 200, same as the previous unconfigurable behavior. Set tonullto restore the default.Fixes SDK-2633
How Has This Been Tested?
added unit tests
Checklist: