fix: disable Config Policies apply after updated to empty#10171
Open
johnkim-det wants to merge 1 commit intomainfrom
Open
fix: disable Config Policies apply after updated to empty#10171johnkim-det wants to merge 1 commit intomainfrom
johnkim-det wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10171 +/- ##
==========================================
- Coverage 54.27% 50.77% -3.50%
==========================================
Files 1259 953 -306
Lines 157285 130301 -26984
Branches 3644 3642 -2
==========================================
- Hits 85359 66159 -19200
+ Misses 71793 64009 -7784
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
CM-595
Description
Apply button stays active after submitting empty file. Should become disabled.
Test Plan
In EE, on Config Policies page:
Edit config policies to valid, non-empty content (ex.
). Then edit to remove all content, and press Apply. At this point, there should be no valid changes to save, so the Apply button should be disabled.
Checklist
docs/release-notes/See Release Note for details.