Skip to content

Fix CI: build and push image only#1275

Open
ogbanugot wants to merge 2 commits intodevelopfrom
fix-ci-loadbalancer
Open

Fix CI: build and push image only#1275
ogbanugot wants to merge 2 commits intodevelopfrom
fix-ci-loadbalancer

Conversation

@ogbanugot
Copy link
Copy Markdown
Contributor

@ogbanugot ogbanugot commented Apr 6, 2026

Closes #<GH_issue_number>

Description of the Problem / Feature

Explanation of the solution

Instructions on making this work

UI changes for review

When major UI changes will happen with this PR, please include links to URLS to compare or screenshots demonstrating the difference and notify design

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow pipelines across multiple services (isolated media server, nodes media, reverse proxy, and main server) to remove automated Kubernetes deployment steps. Workflows now focus exclusively on building and pushing Docker images to container registry, with infrastructure deployment handled separately.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

📝 Walkthrough

Walkthrough

Four GitHub Actions workflows are simplified to focus solely on building and pushing Docker images to ECR. All Kubernetes deployment orchestration, AWS IAM authentication, kubectl operations, and kubeconfig setup steps are removed from the workflows for isolated-media-server, nodes-media, reverse-proxy, and server services.

Changes

Cohort / File(s) Summary
CI/CD Workflow Simplification
.github/workflows/build-isolated-media-server.yaml, .github/workflows/build-nodes-media.yaml, .github/workflows/build-reverse-proxy.yaml, .github/workflows/build-server.yaml
Removed Kubernetes deployment and AWS infrastructure access steps. Workflows now contain only Docker image build and ECR push operations. Deleted AWS IAM authenticator setup, kubectl installation, kubeconfig configuration, EKS deployment steps (DEV/PROD), and rollout verification commands. Job display names updated to reflect build-and-push-only scope.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 We've trimmed the workflows, oh what a sight,
No more kubectl dancing through the night!
Just build and push to ECR we go,
Simple and swift, a streamlined flow! 📦✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix CI: build and push image only' directly and accurately summarizes the main change: removing deployment steps from CI workflows to keep only build and push functionality.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-ci-loadbalancer
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch fix-ci-loadbalancer

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/build-nodes-media.yaml (1)

27-85: ⚠️ Potential issue | 🔴 Critical

Add deployment steps or confirm DEV/PROD rollout is handled elsewhere.

The build-and-push job ends at the ECR push with no kubectl steps. This means develop/main pushes will upload new images but won't update the live Kubernetes Deployments. The manifests at nodes-media/kubernetes/deployment_dev.yaml and deployment_prod.yaml still exist with static :latest image references, yet nothing applies or rolls them out after the ECR push.

The same gap applies to the sibling build workflows: build-isolated-media-server.yaml and build-reverse-proxy.yaml are also build-only with no deployment automation. If DEV/PROD rollouts were intentionally moved to a separate workflow or controller not in this PR, please clarify. Otherwise, add kubectl apply and kubectl set image steps for each branch (or restore them if recently removed).

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/build-nodes-media.yaml around lines 27 - 85, The
build-and-push job currently builds and pushes images (see steps "Build and tag
the image (DEV)" / "Build and tag the image (PROD)" and "Push (DEV)" / "Push
(PROD)") but never deploys them to Kubernetes—so the manifests
nodes-media/kubernetes/deployment_dev.yaml and deployment_prod.yaml are never
applied or updated; add branch-conditional deployment steps after each Push
(DEV)/(PROD) that authenticate to the cluster (kubectl context or aws eks
update-kubeconfig), run kubectl apply -f
nodes-media/kubernetes/deployment_dev.yaml (or deployment_prod.yaml) and then
kubectl set image on the relevant Deployment to the newly pushed tag (use the
image tag output from step image-tag) so that pushes to develop/main trigger
rollout (or, if rollouts are handled elsewhere, add a comment in the workflow
explaining where and how deployments occur).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In @.github/workflows/build-nodes-media.yaml:
- Around line 27-85: The build-and-push job currently builds and pushes images
(see steps "Build and tag the image (DEV)" / "Build and tag the image (PROD)"
and "Push (DEV)" / "Push (PROD)") but never deploys them to Kubernetes—so the
manifests nodes-media/kubernetes/deployment_dev.yaml and deployment_prod.yaml
are never applied or updated; add branch-conditional deployment steps after each
Push (DEV)/(PROD) that authenticate to the cluster (kubectl context or aws eks
update-kubeconfig), run kubectl apply -f
nodes-media/kubernetes/deployment_dev.yaml (or deployment_prod.yaml) and then
kubectl set image on the relevant Deployment to the newly pushed tag (use the
image tag output from step image-tag) so that pushes to develop/main trigger
rollout (or, if rollouts are handled elsewhere, add a comment in the workflow
explaining where and how deployments occur).

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 88fc1fe8-d628-459c-a20d-f2eb8a3ce567

📥 Commits

Reviewing files that changed from the base of the PR and between ad8ab5f and 0687a3f.

📒 Files selected for processing (4)
  • .github/workflows/build-isolated-media-server.yaml
  • .github/workflows/build-nodes-media.yaml
  • .github/workflows/build-reverse-proxy.yaml
  • .github/workflows/build-server.yaml
💤 Files with no reviewable changes (1)
  • .github/workflows/build-server.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant